[Bug ld/24055] _bfd_xcoff_swap_aux_in smashes the stack

[nickc at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=24055

Nick Clifton <nickc at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nickc at redhat dot com

--- Comment #1 from Nick Clifton <nickc at redhat dot com> ---
Created attachment 11507
  --> https://sourceware.org/bugzilla/attachment.cgi?id=11507&action=edit
Proposed patch

Hi Wolfgang,

  I agree that this is a problem, but I do not think that your patch will 
  work.  It will fail to copy auxiliary entries for file symbols, if that
  symbol has more than 1 auxiliary entry.

  I think that the issue is probably that file symbols should never have
  more than one or two auxiliary entries, although I could not find an
  actual specification of that rule.

  Please could you try out this alternate patch, which does not actually
  solve the problem, but it should generate an abort rather than allowing
  the stack to be smashed.  (I am hoping that this will allow you to trace
  the reason for the abort back to a maformed file symbol).

  If the patch works as I hope, then I would also apply it to the other
  versions of the swap_aux_in() function that use the same memcpy
functionality.

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.