bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug gas/24434] Missing testsuite coverage for AVX512F gathers (and scat


From: hjl.tools at gmail dot com
Subject: [Bug gas/24434] Missing testsuite coverage for AVX512F gathers (and scatters?) with no base register
Date: Wed, 10 Apr 2019 14:45:43 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=24434

--- Comment #7 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Jakub Jelinek from comment #6)
> It is not a dup, this PR is about missing testsuite coverage, which is still
> the case on binutils trunk.

If you take out the fix, some tests will fail:

FAIL: ix86 EVEX no disp scaling
FAIL: x86-64 EVEX no disp scaling

commit 629cfaf1b0fbb32a985607c774bd8e7870b9fa94
Author: Jan Beulich <address@hidden>
Date:   Mon Jul 30 17:25:05 2018 +0200

    x86: don't mistakenly scale non-8-bit displacements

    In commit b5014f7af2 I've removed (instead of replaced) a conditional,
    resulting in addressing forms not allowing 8-bit displacements to now
    get their displacements scaled under certain circumstances. Re-add the
    missing conditional.

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 3f5c4e5638..8f77c3d448 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,12 @@
+2018-07-30  Jan Beulich  <address@hidden>
+
+  PR gas/23465
+  * config/tc-i386.c (output_disp): Restrict scaling.
+  * testsuite/gas/i386/evex-no-scale.s,
+    testsuite/gas/i386/evex-no-scale-32.d
+    testsuite/gas/i386/evex-no-scale-64.d: New.
+  * testsuite/gas/i386/i386.exp: Run new tests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]