bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug ld/16720] wrong overflow check in R_MIPS_HI16


From: cvs-commit at gcc dot gnu.org
Subject: [Bug ld/16720] wrong overflow check in R_MIPS_HI16
Date: Tue, 28 May 2019 17:50:15 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=16720

--- Comment #7 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> ---
The master branch has been updated by Faraz Shahbazker <address@hidden>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1e129bbefadbf09ace0fc7fcb3cfcda13700e3b8

commit 1e129bbefadbf09ace0fc7fcb3cfcda13700e3b8
Author: Faraz Shahbazker <address@hidden>
Date:   Thu May 23 18:16:08 2019 -0700

    MIPS/LD: Skip overflow check for %pcrel_hi relocations

    Overflow checks were removed for all hi16 relocations except PC-relative
    high relocations per PR ld/16720.  Remove overflow checks from %pcrel_hi
    relocations so that we can correctly handle negative offsets from PC.

    bfd/
        * elfxx-mips.c (mips_elf_calculate_relocation) <R_MIPS_PCHI16>:
        Remove overflow check.

    ld/
        * testsuite/ld-mips-elf/undefweak-overflow.s: Remove test case
        for pcrel_hi/pcrel_lo.
        * testsuite/ld-mips-elf/undefweak-overflow.d: Update to match.
        * testsuite/ld-mips-elf/reloc-pcrel-r6.s: New test source.
        * testsuite/ld-mips-elf/reloc-pcrel-r6.d: New test linker script.
        * testsuite/ld-mips-elf/reloc-pcrel-r6.ld: New test.
        * testsuite/ld-mips-elf/mips-elf.exp: Run the new test.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]