[Bug binutils/24907] Objdump produces wrong branch opcode interpretation in some cases

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24907

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> ---
The master branch has been updated by Nick Clifton <address@hidden>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=aebcfb76fc165795e67917cb67cf985c4dfdc577

commit aebcfb76fc165795e67917cb67cf985c4dfdc577
Author: Nick Clifton <address@hidden>
Date:   Tue Sep 10 15:20:58 2019 +0100

    Enhance the disassembler so that it will reliably determine whether a reloc
applies to the middle of the next insn.

        PR 24907
    binutils* objdump.c (null_print): New function.
        (disassemble_bytes): Delete previous_octets local and replace with
        a test of the max_reloc_offset_into_insn field of the
        bfd_arch_info structure.  If a reloc is a potential match for the
        next insn, then perform a dummy disassembly in order to calculate
        its real length.

    bfd * archures.c (bfd_arch_info_type): Add max_reloc_offset_into_insn
        field.
        (bfd_default_arch_struct): Initialise the new field.
        * bfd-in2.h: Regenerate.
        * cpu-aarch64.c: Initialise the new field.
        * cpu-alpha.c: Likewise.
        * cpu-arc.c: Likewise.
        * cpu-arm.c: Likewise.
        * cpu-avr.c: Likewise.
        * cpu-bfin.c: Likewise.
        * cpu-bpf.c: Likewise.
        * cpu-cr16.c: Likewise.
        * cpu-cr16c.c: Likewise.
        * cpu-cris.c: Likewise.
        * cpu-crx.c: Likewise.
        * cpu-csky.c: Likewise.
        * cpu-d10v.c: Likewise.
        * cpu-d30v.c: Likewise.
        * cpu-dlx.c: Likewise.
        * cpu-epiphany.c: Likewise.
        * cpu-fr30.c: Likewise.
        * cpu-frv.c: Likewise.
        * cpu-ft32.c: Likewise.
        * cpu-h8300.c: Likewise.
        * cpu-hppa.c: Likewise.
        * cpu-i386.c: Likewise.
        * cpu-ia64.c: Likewise.
        * cpu-iamcu.c: Likewise.
        * cpu-ip2k.c: Likewise.
        * cpu-iq2000.c: Likewise.
        * cpu-k1om.c: Likewise.
        * cpu-l1om.c: Likewise.
        * cpu-lm32.c: Likewise.
        * cpu-m10200.c: Likewise.
        * cpu-m10300.c: Likewise.
        * cpu-m32c.c: Likewise.
        * cpu-m32r.c: Likewise.
        * cpu-m68hc11.c: Likewise.
        * cpu-m68hc12.c: Likewise.
        * cpu-m68k.c: Likewise.
        * cpu-m9s12x.c: Likewise.
        * cpu-m9s12xg.c: Likewise.
        * cpu-mcore.c: Likewise.
        * cpu-mep.c: Likewise.
        * cpu-metag.c: Likewise.
        * cpu-microblaze.c: Likewise.
        * cpu-mips.c: Likewise.
        * cpu-mmix.c: Likewise.
        * cpu-moxie.c: Likewise.
        * cpu-msp430.c: Likewise.
        * cpu-mt.c: Likewise.
        * cpu-nds32.c: Likewise.
        * cpu-nfp.c: Likewise.
        * cpu-nios2.c: Likewise.
        * cpu-ns32k.c: Likewise.
        * cpu-or1k.c: Likewise.
        * cpu-pdp11.c: Likewise.
        * cpu-pj.c: Likewise.
        * cpu-plugin.c: Likewise.
        * cpu-powerpc.c: Likewise.
        * cpu-pru.c: Likewise.
        * cpu-riscv.c: Likewise.
        * cpu-rl78.c: Likewise.
        * cpu-rs6000.c: Likewise.
        * cpu-rx.c: Likewise.
        * cpu-s12z.c: Likewise.
        * cpu-s390.c: Likewise.
        * cpu-score.c: Likewise.
        * cpu-sh.c: Likewise.
        * cpu-sparc.c: Likewise.
        * cpu-spu.c: Likewise.
        * cpu-tic30.c: Likewise.
        * cpu-tic4x.c: Likewise.
        * cpu-tic54x.c: Likewise.
        * cpu-tic6x.c: Likewise.
        * cpu-tic80.c: Likewise.
        * cpu-tilegx.c: Likewise.
        * cpu-tilepro.c: Likewise.
        * cpu-v850.c: Likewise.
        * cpu-v850_rh850.c: Likewise.
        * cpu-vax.c: Likewise.
        * cpu-visium.c: Likewise.
        * cpu-wasm32.c: Likewise.
        * cpu-xc16x.c: Likewise.
        * cpu-xgate.c: Likewise.
        * cpu-xstormy16.c: Likewise.
        * cpu-xtensa.c: Likewise.
        * cpu-z80.c: Likewise.
        * cpu-z8k.c: Likewise.

    gas * testsuite/gas/arm/pr24907.s: New test.
        * testsuite/gas/arm/pr24907.d: Expected disassembly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.