[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug binutils/25180] Slowness in cplus_demangle()

From: nickc at redhat dot com
Subject: [Bug binutils/25180] Slowness in cplus_demangle()
Date: Tue, 12 Nov 2019 12:35:12 +0000


--- Comment #7 from Nick Clifton <nickc at redhat dot com> ---
Hi Tim,

(In reply to Tim Rühsen from comment #6)
> the attached patch fixes the demangler slowness (see commit message for a
> description).

Did you run the libiberty testsuite to see if it introduces any new failures ?
Also it would be a good idea to run the g++ testsuite as well, just in case...

Given that you check for "d->d_counting > 1", would it make more sense to make
that field a boolean ?  If not, then should the limit be configurable somehow ?

Other than that though the patch looks fine to me, but of course I cannot
approve it.  Are you going to submit it to gcc-patches ?


You are receiving this mail because:
You are on the CC list for the bug.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]