[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug binutils/25197] binutils/nm-new: BFD (GNU Binutils) 2.33 assertion
cvs-commit at gcc dot gnu.org
[Bug binutils/25197] binutils/nm-new: BFD (GNU Binutils) 2.33 assertion fail coffgen.c:2381
Tue, 19 Nov 2019 02:04:49 +0000
--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot
The master branch has been updated by Alan Modra <address@hidden>:
Author: Alan Modra <address@hidden>
Date: Tue Nov 19 11:38:36 2019 +1030
PR25197, assertion fail coffgen.c
The testcase in this PR triggered "BFD_ASSERT (p2->is_sym)" by
sneakily generating a C_FILE sym whose value pointed into auxents.
The fix then is in the last changed line of this patch, to check
p->is_sym as well as p->u.syment.n_sclass. The other changes fix
various overflow checks that weren't as solid as they could be.
* coffgen.c (coff_find_nearest_line_with_names): Check that C_FILE
u.syment.n_value does point at another C_FILE sym and not into
some auxent that happens to look like a C_FILE. Properly check
for integer overflow and avoid possible pointer wrap-around.
Simplify pr17512 checks.
You are receiving this mail because:
You are on the CC list for the bug.