bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug ld/25384] Copy relocations and BIND_NOW on POWER ELFv1 results in c


From: cvs-commit at gcc dot gnu.org
Subject: [Bug ld/25384] Copy relocations and BIND_NOW on POWER ELFv1 results in crashes
Date: Wed, 15 Jan 2020 02:44:17 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=25384

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> ---
The master branch has been updated by Alan Modra <address@hidden>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e1c6cf618cbeebbafd34afc5ee921fcbf7061bfa

commit e1c6cf618cbeebbafd34afc5ee921fcbf7061bfa
Author: Alan Modra <address@hidden>
Date:   Tue Jan 14 20:45:53 2020 +1030

    PR25384, PowerPC64 ELFv1 copy relocs against function symbols

    Function symbols of course don't normally want .dynbss copies but
    with some old versions of gcc they are needed to copy the function
    descriptor.  This patch restricts the cases where they are useful to
    compilers using dot-symbols, and enables the warning regardless of
    whether a PLT entry is emitted in the executable.  PLTs in shared
    libraries are affected by a .dynbss copy in the executable.

    bfd/
        PR 25384
        * elf64-ppc.c (ELIMINATE_COPY_RELOCS): Update comment.
        (ppc64_elf_adjust_dynamic_symbol): Don't allow .dynbss copies
        of function symbols unless dot symbols are present.  Do warn
        whenever one is created, regardles of whether a PLT entry is
        also emitted for the function symbol.
    ld/
        * testsuite/ld-powerpc/ambiguousv1b.d: Adjust expected output.
        * testsuite/ld-powerpc/funref.s: Align func_tab.
        * testsuite/ld-powerpc/funref2.s: Likewise.
        * testsuite/ld-powerpc/funv1.s: Add dot symbols.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]