bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug ld/25569] PDP11 ld -s clobbers last data byte


From: cvs-commit at gcc dot gnu.org
Subject: [Bug ld/25569] PDP11 ld -s clobbers last data byte
Date: Fri, 21 Feb 2020 00:18:13 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=25569

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> ---
The master branch has been updated by Alan Modra <address@hidden>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=dda2980f54a0c9437de047f3020f520dd1e0de6a

commit dda2980f54a0c9437de047f3020f520dd1e0de6a
Author: Alan Modra <address@hidden>
Date:   Thu Feb 20 21:53:44 2020 +1030

    PR25569, PDP11 ld -s clobbers last data byte

    This patch fixes an ancient wart in aout support, in that text and
    data section sizes are rounded up for alignment rather that just the
    corresponding header sizes.  Changing section sizes could conceivably
    result in buffer overflows if section contents were held in memory.
    Also, keeping the original section sizes allows this PR to be fixed
    nicely.

    bfd/
        PR 25569
        * aoutx.h (adjust_o_magic, adjust_z_magic, adjust_n_magic): Use
        "text", "data" and "bss" section pointer vars.  Don't update
        section size, just exec header sizes.
        (adjust_sizes_and_vmas): Don't update text section size.  Set
        initial exec header a_text.  Print exec headers sizes.
        * pdp11.c (adjust_o_magic, adjust_z_magic, adjust_n_magic),
        (adjust_sizes_and_vmas): Similarly.  Formatting.
        (final_link): Correct final file extension.
    gas/
        PR 25569
        * config/obj-aout.c (obj_aout_frob_file_before_fix): Don't loop
        on section size adjustment, instead perform another write if
        exec header size is larger than section size.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]