[Bug gas/25614] dwarf-5 allows for .file 0

[dblaikie at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25614

--- Comment #16 from David Blaikie <dblaikie at gmail dot com> ---
(In reply to address@hidden from comment #15)
> The master branch has been updated by Maciej W. Rozycki
> <address@hidden>:
> 
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;
> h=876678f05e70235ed71d5b9ec63e4f6db1ec76e4
> 
> commit 876678f05e70235ed71d5b9ec63e4f6db1ec76e4
> Author: Maciej W. Rozycki <address@hidden>
> Date:   Tue Mar 31 23:01:36 2020 +0100
> 
>     PR 25611, PR 25614: GAS: Remove a double inclusion of "bignum.h"
>     
>     Correct an issue with commit 5496f3c635dc ("Add support for generating
>     DWARF-5 format directory and file name tables from the assembler.") and
>     remove a duplicate direct inclusion of "bignum.h" from dwarf2dbg.c that
>     causes a GAS compilation error:
>     
>     In file included from .../gas/dwarf2dbg.c:33:
>     .../gas/bignum.h:42: error: redefinition of typedef 'LITTLENUM_TYPE'
>     .../gas/bignum.h:42: error: previous declaration of 'LITTLENUM_TYPE' was
> here
>     make[4]: *** [dwarf2dbg.o] Error 1
>     
>     with some GCC versions, as this header has been already included via
>     "as.h" and then "flonum.h".
>     
>             gas/
>             PR 25611
>             PR 25614
>             * dwarf2dbg.c: Do not include "bignum.h".

bignum.h seems brittle - I guess there's a reason it doesn't have include
guards? (if it doesn't have include guards, perhaps it shouldn't be included
from other headers? Maybe given a different extension?)

-- 
You are receiving this mail because:
You are on the CC list for the bug.