bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug ld/25677] Changes to --*magic options for pdp11-aout target


From: casner at acm dot org
Subject: [Bug ld/25677] Changes to --*magic options for pdp11-aout target
Date: Thu, 09 Apr 2020 14:46:36 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=25677

--- Comment #13 from Stephen Casner <casner at acm dot org> ---
(In reply to Nick Clifton from comment #12)
> You appear to be submitting the same patch as Jan... :-)
> 
> The patch has the same problem as outlined here:
> 
>   https://sourceware.org/pipermail/binutils/2020-April/110597.html
> 
> Basically the definitions of coff_swap_scnhdr_[in|out] need to
> be changed so that other COFF based targets will build.

Nick, perhaps some wires got crossed here?  Perhaps you had two patches applied
when you checked mine?  My patch should not have any effect on any COFF based
targets because the changes are almost entirely within the files specific to
the pdp11-aout target.  The only changes in common code are:

  - I needed to add i_magic to enum aout_magic in bfd/libaout.h.

  - In ld/lexsup.c, I needed to set config.text_read_only to TRUE in
    case 'n'.  This is the same as the default value of that boolean
    as initialized in ldmain.c so I assume my change won't affect any
    non-pdp11 emulation.  I need this change so that my change of the
    default value for pdp11 will work.  That boolean is initialized to
    FALSE or TRUE in case 'N' and case OPTION_NO_OMAGIC.

  - In include/aout/aout64.h I needed to define IMAGIC and add two lines
    in N_DATADDR to return 0 when the magic number is IMAGIC.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]