bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug gas/26025] riscv gas inserts relocation for BFD_RELOC_RISCV_CFA in


From: wilson at gcc dot gnu.org
Subject: [Bug gas/26025] riscv gas inserts relocation for BFD_RELOC_RISCV_CFA in last section of file, instead of relevant section
Date: Sun, 24 May 2020 00:34:02 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=26025

Jim Wilson <wilson at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
                 CC|                            |wilson at gcc dot gnu.org
     Ever confirmed|0                           |1
           Assignee|unassigned at sourceware dot org   |wilson at gcc dot 
gnu.org
   Last reconfirmed|                            |2020-05-24

--- Comment #2 from Jim Wilson <wilson at gcc dot gnu.org> ---
I see that the frag code makes a distinction between inserting frags before the
frag chains are chained together and afterward.  After chaining, we need to set
now_seg before creating the frag.  tc-xtensa.c has a function called
fix_new_exp_in_seg that handles this right, but switches segments twice each
time it is called.  In this case, we can inline it and pull the save and
restore out of the loop.  That gives effectively the same patch you wrote.  I
added comments, and have some slightly different variable names.

Do you have an FSF copyright assignment?  I don't see an obvious one.  If not,
I can use the patch I wrote.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]