[Bug ld/26080] Incorrect "Common symbol override test"

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26080

--- Comment #8 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c4b126b87a6cd842e567136b07ac1adca98c660f

commit c4b126b87a6cd842e567136b07ac1adca98c660f
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Jun 4 05:58:34 2020 -0700

    ELF: Don't check relocations in non-loaded, non-alloced sections

    Don't do anything special with non-loaded, non-alloced sections.
    In particular, any relocs in such sections should not affect GOT
    and PLT reference counting (ie. we don't allow them to create GOT
    or PLT entries), there's no possibility or desire to optimize TLS
    relocs, and there's not much point in propagating relocs to shared
    libs that the dynamic linker won't relocate.

    Since check_relocs is no longer called on non-loaded, non-alloced
    sections, remove SEC_ALLOC check.  Resolve relocation in debug section
    against symbol defined in shared library to 0.

    bfd/

            PR ld/26080
            * elf-m10300.c (mn10300_elf_relocate_section): Resolve relocation
            in debug section against symbol defined in shared library to 0.
            * elf32-i386.c (elf_i386_check_relocs): Remove SEC_ALLOC check.
            * elf32-lm32.c (lm32_elf_check_relocs): Likewise.
            * elf32-m32r.c (m32r_elf_check_relocs): Likewise.
            * elf32-nds32.c (nds32_elf_check_relocs): Likewise.
            * elf32-nios2.c (nios2_elf32_check_relocs): Likewise.
            * elf32-or1k.c (or1k_elf_check_relocs): Likewise.
            * elf32-ppc.c (ppc_elf_check_relocs): Likewise.
            * elf32-sh.c (sh_elf_check_relocs): Likewise.
            * elf32-xtensa.c (elf_xtensa_check_relocs): Likewise.
            * elf64-alpha.c (elf64_alpha_check_relocs): Likewise.
            * elf64-ppc.c (ppc64_elf_check_relocs): Likewise.
            * elf64-x86-64.c (elf_x86_64_check_relocs): Likewise.
            * elfxx-mips.c (_bfd_mips_elf_check_relocs): Likewise.
            * elf32-vax.c (elf_vax_check_relocs): Set non_got_ref for non-GOT
            reference.
            (elf_vax_adjust_dynamic_symbol): Generate a copy reloc only if
            there is non-GOT reference.
            * elflink.c (_bfd_elf_link_check_relocs): Skip non-loaded,
            non-alloced sections.

    ld/

            PR ld/26080
            * testsuite/ld-elf/comm-data.exp: Remove copy_reloc.
            * testsuite/ld-elf/comm-data2r.rd: Removed.
            * testsuite/ld-elf/comm-data2r.sd: Likewise.
            * testsuite/ld-elf/comm-data2r.xd: Likewise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.