[Bug gold/25975] --dynamic-list doesn't work correctly

[i at maskray dot me]

https://sourceware.org/bugzilla/show_bug.cgi?id=25975

--- Comment #22 from Fangrui Song <i at maskray dot me> ---
(In reply to H.J. Lu from comment #20)
>   // If the symbol was forced dynamic in a --dynamic-list file
>   // or an --export-dynamic-symbol option, add it.
>   if (!this->is_from_dynobj()
>       && (parameters->options().in_dynamic_list(this->name())
>           || parameters->options().is_export_dynamic_symbol(this->name())))
>     {    
>       if (!this->is_forced_local())
>         return true;
>       gold_warning(_("Cannot export local symbol '%s'"),
>                    this->demangled_name().c_str());
>       return false;
>     }    
> 
> I don't think the warning is necessary when it is a wild card match.

Agreed. clang -fsanitize=address uses --dynamic-list when
libclang_rt.asan-x86_64.a.syms exists. This behavior has been there for a long
time, since 3.3
(https://github.com/llvm/llvm-project/commit/f3e624ca73b007552554b31358f4abde9eb2d3b7
). So the gold warning may be there for a long time as well.

% readelf -Ws lib/clang/11.0.0/lib/linux/libclang_rt.asan-x86_64.a | grep
__asan_extra_spill_area
   251: 0000000000000000    48 FUNC    GLOBAL HIDDEN   162
__asan_extra_spill_area
     6: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT  UND
__asan_extra_spill_area

The spurious warning should just be deleted, along with msgid "Cannot export
local symbol '%s'" in various .po files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.