[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug ld/22269] Undefined weak symbols isn't resolved to 0 in static PIE
From: |
cvs-commit at gcc dot gnu.org |
Subject: |
[Bug ld/22269] Undefined weak symbols isn't resolved to 0 in static PIE |
Date: |
Tue, 15 Sep 2020 02:00:03 +0000 |
https://sourceware.org/bugzilla/show_bug.cgi?id=22269
--- Comment #43 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot
gnu.org> ---
The binutils-2_35-branch branch has been updated by Hans-Peter Nilsson
<hp@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ef6b667ead5c32c7d26faffff58f1f86f70a662b
commit ef6b667ead5c32c7d26faffff58f1f86f70a662b
Author: Hans-Peter Nilsson <hp@axis.com>
Date: Tue Sep 15 03:59:06 2020 +0200
CRIS: fix PR ld/26589, a missing NULL check in fix for PR ld/22269
Not sure why there wasn't a NULL check in the ld/22269 patch
(e01c16a8) at the time, as there was one for the corresponding patch
to elf32-m68k.c (5056ba1d).
Incidentally, I had missed that in 2017, as a prerequisite for the
ld/22269 series, the check_relocs function finally were made "safe"!
(I.e. the number of references and symbol types are final, garbage
collection done, so port-specific accounting can be made sanely.)
Committed.
bfd:
PR ld/26589
* elf32-cris.c (cris_elf_check_relocs): Add missing NULL check
on argument before calling UNDEFWEAK_NO_DYNAMIC_RELOC.
ld:
PR ld/26589
* testsuite/ld-elf/pr26589.d, testsuite/ld-elf/locref3.s: New test.
(cherry picked from commit 4a8f181d196f85ca153fe51ca6bb40942e0e1ed7)
--
You are receiving this mail because:
You are on the CC list for the bug.