[Bug binutils/4356] windres fails on files with spaces

[eliz at gnu dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=4356

Eli Zaretskii <eliz at gnu dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eliz at gnu dot org

--- Comment #11 from Eli Zaretskii <eliz at gnu dot org> ---
I think that the solutions proposed for this bug are flawed, because they paper
over the real problem.  The real problem is the function 'quot': it is there to
quote special characters that can confuse the shell, but the method it uses to
quote -- escape-protect each special character with a backslash -- works only
for Posix shells.  For Windows shells we need to quote "like this", i.e.
enclose the whole string in double quotes (and escape-protect any embedded
quotes with a backslash).

The attached patch modifies 'quot' to DTRT on MS-Windows.  I tested it, and it
works in all the test cases I threw on it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.