bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug ld/27433] RISC-V linker might lose relax opportunities since "again


From: nelsonc1225 at sourceware dot org
Subject: [Bug ld/27433] RISC-V linker might lose relax opportunities since "again" doesn't work as expected
Date: Thu, 11 Mar 2021 09:55:49 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=27433

--- Comment #5 from Nelson Chu <nelsonc1225 at sourceware dot org> ---
Oh I forgot to add the PR27433 in the comment, so it doesn’t show which commit
fixes this PR.

commit ebdcad3fddf6ec21f6d4dcc702379a12718cf0c4
Refs: [master], {upstream-write/master},
users/ARM/embedded-gdb-master-2018q4-9197-gebdcad3
Author:     Nelson Chu <nelson.chu@sifive.com>
AuthorDate: Fri Dec 18 10:59:41 2020 +0800
Commit:     Nelson Chu <nelson.chu@sifive.com>
CommitDate: Thu Mar 11 17:27:13 2021 +0800

    RISC-V: Improve multiple relax passes problem.


(In reply to Jim Wilson from comment #4)
> I don't see another target that does the same thing, but I do see multiple
> targets with size_stub hooks that can call ldelf_map_segments multiple
> times, so clearly this should work.
> 
> Worst case, we could always increase the relax pass count.  We could have 7
> passes instead of 4 for instance, where 0, 1, 2 are the same as current
> passes, then 3, 4, 5 as same as 0, 1, 2 if necessary, and then pass 7 is
> same as current pass 3 for alignment relaxation.  But I don't think that is
> necessary.  Your patch should work.

Thanks for clarifying these.

> I noticed a few minor comment typos
> itslef -> itself
> relxations -> relaxations
> and from a previous patch that I missed
> obselete -> obsolete

Fixed!

> I'm curious how this affects link time, but since few relaxations will happen
> on the second time through I don't think it will matter much.  I can check
> native glibc build times after you commit the patch.

I have ran and passed the toolchain regressions again, so the patch is
committed for now.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]