[Bug binutils/26945] Unsafe chown+chmod in smart_rename, possibly elsewhere

[dongjianqiang2 at huawei dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26945

John Dong <dongjianqiang2 at huawei dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dongjianqiang2 at huawei dot 
com

--- Comment #22 from John Dong <dongjianqiang2 at huawei dot com> ---
(In reply to cvs-commit@gcc.gnu.org from comment #21)
> The binutils-2_36-branch branch has been updated by Alan Modra
> <amodra@sourceware.org>:
> 
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;
> h=d3edaa91d4cf7202ec14342410194841e2f67f12
> 
> commit d3edaa91d4cf7202ec14342410194841e2f67f12
> Author: Alan Modra <amodra@gmail.com>
> Date:   Fri Feb 26 11:30:32 2021 +1030
> 
>     Reinstate various pieces backed out from smart_rename changes
>     
>     In the interests of a stable release various last minute smart_rename
>     patches were backed out of the 2.36 branch.  The main reason to
>     reinstate some of those backed out changes here is to make necessary
>     followup fixes to commit 8e03235147a9 simple cherry-picks from
>     mainline.  A secondary reason is that ar -M support isn't fixed for
>     pr26945 without this patch.
>     
>             PR 26945
>             * ar.c: Don't include libbfd.h.
>             (write_archive): Replace xmalloc+strcpy with xstrdup.
>             * arsup.c (temp_name, real_ofd): New static variables.
>             (ar_open): Use make_tempname and bfd_fdopenw.
>             (ar_save): Adjust to suit ar_open changes.
>             * objcopy.c: Don't include libbfd.h.
>             * rename.c: Rename and reorder variables.
>     
>     (cherry picked from commit 95b91a043aeaeb546d2fea556d84a2de1e917770)

Hi, can we backport this patch to binutils-2_34-branch ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.