bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug binutils/27594] build processes broken by changed space handling


From: eliz at gnu dot org
Subject: [Bug binutils/27594] build processes broken by changed space handling
Date: Mon, 10 May 2021 17:45:26 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=27594

--- Comment #13 from Eli Zaretskii <eliz at gnu dot org> ---
I think I see what caused the breakage of the MSYS2 build script.  It wasn't
the change in `quot`, it was a previous commit 21c33bc, which attempted to fix
PR 26865.  The change in that commit encloses the --preprocessor argument in
double quotes if it includes whitespace.  Which is correct if the argument is a
single file, as it should be.  But if it is used to pass a complete
preprocessor shell command, and the scripts which used that loophole were
working around the invalid usage by pre-quoting the argument, then indeed those
scripts will break.

So bottom line: the revert reverted the wrong commit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]