[Bug binutils/27594] build processes broken by changed space handling

[martin at martin dot st]

https://sourceware.org/bugzilla/show_bug.cgi?id=27594

--- Comment #19 from Martin Storsjö <martin at martin dot st> ---
(In reply to Eli Zaretskii from comment #18)
> Moreover, `windres` calls `popen` only in its default mode; you could change
> that with the --use-temp-file option, in which case the preprocessor will be
> invoked via `pexecute`, and that has a different set of
> implementation-defined perculiarities wrt quoted parts of the command.

When windres calls pexecute, windres itself splits the string (which is in a
quoted/escaped form suitable for passing to popen) in the run_cmd function, so
run_cmd is supposed to split/unescape things in the same way as the shell
would. So ideally, the distinction between those two souldn't be visible
externally.

> > Whether the wrong commit was reverted or not I cannot judge right now, I was
> > only asking to restore the 2.35 behaviour which is consistent with general
> > POSIX string handling and which supports everything anyone needs. Breaking
> > such support after years is what's generally called a regression and it's
> > generally and rightfully frowned upon.
> 
> I disagree here as well.  If someone used the tool incorrectly, in direct
> contradiction to its docs, then backward compatibility doesn't apply, IMO. 

This is indeed the core of the issue.

Up until the 2.35 version, the option was documented as "This option may be
used to specify the preprocessor to use, including any leading arguments. The
default preprocessor argument is `gcc -E -xc-header -DRC_INVOKED`." I think
that's rather clearly saying that this kind of behaviour was explicitly
intended and allowed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.