bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug binutils/27594] build processes broken by changed space handling


From: eliz at gnu dot org
Subject: [Bug binutils/27594] build processes broken by changed space handling
Date: Thu, 13 May 2021 14:15:47 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=27594

--- Comment #23 from Eli Zaretskii <eliz at gnu dot org> ---
(In reply to Nick Clifton from comment #22)
> Hi Guys,
> 
>   I am hoping that we can all reach an agreement on how this issue should be
> handled.
> 
>   To be clear, my opinion is that previously the documentation was incorrect.
> I do not believe that it was ever the intention that the --preprocessor
> option should also accept command line options.  It did, yes, and in fact it
> still does, but it should not be relied upon.  Arguments to the preprocessor
> should always be passed via the --preprocessor-arg option.
> 
>   So I think that the documentation is now correct.  But we still need to
> agree on how spaces should be handled.  I am not going to propose any more
> patches however.  I am going to leave that up to you guys.  Come to an
> agreement.  Propose a patch and I will review and apply it.

The problem here is that people disagree that --preprocessor should only accept
the program's file name.  As long as this basic disagreement is unresolved,
there could be no agreement about the patch.

Personally, I agree with Nick's opinion on this.  If this opinion is accepted,
then the code as it was before cc3edc52747fd8b184ee48f1b0cc1ac0aca7832e was
reverted, is 100% correct.  If Nick's opinion is NOT accepted, then at least
commit 749c700282097cf679ff019a9674d7c762f48619 should be reverted, as it
changed the function `quot` which is not related to handling of --preprocessor.
 Can we at least agree on this latter point?

-- 
You are receiving this mail because:
You are on the CC list for the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]