[Bug binutils/27594] build processes broken by changed space handling

[martin at martin dot st]

https://sourceware.org/bugzilla/show_bug.cgi?id=27594

--- Comment #24 from Martin Storsjö <martin at martin dot st> ---
(In reply to Nick Clifton from comment #22)
>   To be clear, my opinion is that previously the documentation was incorrect.
> I do not believe that it was ever the intention that the --preprocessor
> option should also accept command line options.  It did, yes, and in fact it
> still does, but it should not be relied upon.  Arguments to the preprocessor
> should always be passed via the --preprocessor-arg option.

This is indeed the core of the issue.

I can't speculate on what the original intention of the option was, but the
docs did say explicitly "including any leading arguments", and then also went
on to mention the default option value including extra arguments. And as this
documentation matched how it behaved in practice, I'd say it has been hard for
users to guess that the intent of the option to be used that way.

I guess the alternative is to more clearly say that we're intentionally
changing (or, already changed) the behaviour to clarify and simplify it, and
are accepting some collateral breakage. It's primarily the faulting of the
users for doing what the docs said, that I'm objecting to.

(In reply to Eli Zaretskii from comment #23)
> then at least commit
> 749c700282097cf679ff019a9674d7c762f48619 should be reverted, as it changed
> the function `quot` which is not related to handling of --preprocessor.  Can
> we at least agree on this latter point?

Yes, full agree on that part.

-- 
You are receiving this mail because:
You are on the CC list for the bug.