bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug gas/28230] .tfloat change breaks existing assembly codes


From: jbeulich at suse dot com
Subject: [Bug gas/28230] .tfloat change breaks existing assembly codes
Date: Mon, 16 Aug 2021 06:38:49 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=28230

--- Comment #1 from Jan Beulich <jbeulich at suse dot com> ---
sysdeps/x86_64/fpu/s_log1pl.S otoh has

        .align ALIGNARG(4)
        /* The fyl2xp1 can only be used for values in
                -1 + sqrt(2) / 2 <= x <= 1 - sqrt(2) / 2
           0.29 is a safe value.
        */
limit:  .tfloat 0.29
        /* Please note:  we use a double value here.  Since 1.0 has
           an exact representation this does not effect the accuracy
           but it helps to optimize the code.  */
one:    .double 1.0

where pretty clearly .tfloat is expected to behave in an ABI-conforming way.

The use of ".byte 0, 0, 0, 0, 0, 0" is dubious - should be .align (or one of
the variants) instead imo. See e.g. sysdeps/i386/fpu/s_asinhl.S where alignment
is being enforced.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]