bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug gold/28192] powerpc64le: gold generates wrong address with a reloca


From: cvs-commit at gcc dot gnu.org
Subject: [Bug gold/28192] powerpc64le: gold generates wrong address with a relocation of symbol+offset@got@pcrel
Date: Fri, 17 Sep 2021 22:58:16 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=28192

--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> ---
The master branch has been updated by Alan Modra <amodra@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=54721a930e80a635d3cb47c0ad3899ed9680bd78

commit 54721a930e80a635d3cb47c0ad3899ed9680bd78
Author: Alan Modra <amodra@gmail.com>
Date:   Sat Aug 28 14:45:53 2021 +0930

    [GOLD] Output_data_got tidy

    Some Output_data_got methods already have support for addends, but
    were implemented as separate methods.  This removes unnecessary code
    duplication.

    Relobj::local_has_got_offset and others there get a similar treatment.
    Comments are removed since it should be obvious without a comment, and
    the existing comments are not precisely what the code does.  For
    example, a local_has_got_offset call without an addend does not return
    whether the local symbol has *a* GOT offset of type GOT_TYPE, it
    returns whether there is a GOT entry of type GOT_TYPE for the symbol
    with addend of zero.

            PR 28192
            * output.h (Output_data_got::add_local): Make addend optional.
            (Output_data_got::add_local_with_rel): Likewise.
            (Output_data_got::add_local_pair_with_rel): Likewise.
            * output.cc (Output_data_got::add_local): Delete overload
            without addend.
            (Output_data_got::add_local_with_rel): Likewise.
            (Output_data_got::add_local_pair_with_rel): Likewise.
            * object.h (Relobj::local_has_got_offset): Make addend optional.
            Delete overload without addend later.  Update comment.
            (Relobj::local_got_offset): Likewise.
            (Relobj::set_local_got_offset): Likewise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]