bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug gas/28793] [RISC-V] DW_cfa_advance_offset is not correct


From: nelsonc1225 at sourceware dot org
Subject: [Bug gas/28793] [RISC-V] DW_cfa_advance_offset is not correct
Date: Thu, 20 Jan 2022 02:02:33 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=28793

Nelson Chu <nelsonc1225 at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nelsonc1225 at sourceware dot 
org

--- Comment #1 from Nelson Chu <nelsonc1225 at sourceware dot org> ---
The root cause might be here as you have mentioned in another thread,
https://github.com/bminor/binutils-gdb/blob/master/gas/dw2gencfi.c#L1586

In the output_cfi_insn, we will insert the relocation for DW_CFA_advance_loc
only when the "to" and "from" fragments are different.  So your solution looks
reasonable.  Just that I think we probably can start a new frag just in the
riscv_frag_align_code, rather than create a new s_riscv_align.  That is - add
"frag_wane (frag_now) + frag_new (0)" before we call the frag_more in the
riscv_frag_align_code.

Not sure if there will be any side effects, since I haven't run the toolchain
regression for this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]