[Bug ld/28816] ../include/elf/common.h:1409:0: error: "AT_SUN_HWCAP" redefined [-Werror]

[address@hidden]

https://sourceware.org/bugzilla/show_bug.cgi?id=28816

--- Comment #4 from Klaus Ziegler <klausz@haus-gisela.de> ---
On 1/25/22 18:34, nickc at redhat dot com wrote:
> https://sourceware.org/bugzilla/show_bug.cgi?id=28816
>
> Nick Clifton <nickc at redhat dot com> changed:
>
>             What    |Removed                     |Added
> ----------------------------------------------------------------------------
>               Status|UNCONFIRMED                 |RESOLVED
>                   CC|                            |nickc at redhat dot com
>           Resolution|---                         |FIXED
>
> --- Comment #3 from Nick Clifton <nickc at redhat dot com> ---
> Hi Klaus,
>
>    Thanks for reporting this problem.  I have gone ahead and applied your 
> patch.
>
> Cheers
>    Nick
>
Hi Nick,

much appreciated, however there are still errors
building current binutilities on illumos in:
sim/erc32/erc32.c
sim/erc32/interf.c
sim/erc32/sis.c
they all miss <fcntl.h> on illumos, I patched them
this way:
--- sim/erc32/erc32.c.orig    2022-01-24 17:46:12.448917032 +0000
+++ sim/erc32/erc32.c    2022-01-26 08:46:31.264843513 +0000
@@ -32,6 +32,9 @@
  #include <unistd.h>
  #include "sis.h"
  #include "sim-config.h"
+#ifdef __sun
+#include <fcntl.h>
+#endif
would such a patch be suitable for you? - if so I would just open
a new ticket for the above three ones.

The following errors are all related to gdb only, the next two object
files do not compile using: gcc 7.5.0 however using: gcc 10.3.0 they
compile fine without any warning:
gdb/bt-utils.o:
bt-utils.c: In function 'int libbacktrace_print(void*, gl_uintptr_t, 
const char*, int, const char*)':
bt-utils.c:92:53: error: format '%x' expects argument of type 'unsigned 
int', but argument 4 has type 'gl_uintptr_t {aka long unsigned int}' 
[-Werror=format=]
    snprintf (buf, sizeof (buf), "0x%" PRIxPTR " ", pc);
gdb/sol-thread.o:
sol-thread.c: In member function 'virtual void 
sol_thread_target::resume(ptid_t, int, gdb_signal)':
sol-thread.c:417:20: error: format '%ld' expects argument of type 'long 
int', but argument 2 has type 'ULONGEST {aka long long unsigned int}' 
[-Werror=format=]
     save_ptid.tid ());
     ~~~~~~~~~~~~~~~~^
sol-thread.c: In member function 'virtual ptid_t 
sol_thread_target::wait(ptid_t, target_waitstatus*, target_wait_flags)':
sol-thread.c:439:27: error: format '%ld' expects argument of type 'long 
int', but argument 2 has type 'ULONGEST {aka long long unsigned int}' 
[-Werror=format=]
     ptid_for_warning.tid ());
     ~~~~~~~~~~~~~~~~~~~~~~~^
sol-thread.c: In member function 'virtual std::__cxx11::string 
sol_thread_target::pid_to_str(ptid_t)':
sol-thread.c:977:21: error: format '%ld' expects argument of type 'long 
int', but argument 2 has type 'ULONGEST {aka long long unsigned int}' 
[-Werror=format=]
           ptid.tid ());
           ~~~~~~~~~~~^
sol-thread.c:980:33: error: format '%ld' expects argument of type 'long 
int', but argument 2 has type 'ULONGEST {aka long long unsigned int}' 
[-Werror=format=]
           ptid.tid (), lwp.lwp ());
           ~~~~~~~~~~~            ^
sol-thread.c:983:21: error: format '%ld' expects argument of type 'long 
int', but argument 2 has type 'ULONGEST {aka long long unsigned int}' 
[-Werror=format=]
           ptid.tid ());

unfortunately this one I'm unable to fix, and it does not compile using 
gcc7 or gcc10 on illumos:
gdb/procfs.o:
procfs.c: In member function 'virtual bool 
procfs_target::info_proc(const char*, info_proc_what)':
procfs.c:3302:3: error: 'gdb_argv' was not declared in this scope
    gdb_argv built_argv (args);
    ^~~~~~~~
procfs.c:3302:3: note: suggested alternative: 'gdbarch'
    gdb_argv built_argv (args);
    ^~~~~~~~
    gdbarch
procfs.c:3303:20: error: 'built_argv' was not declared in this scope
    for (char *arg : built_argv)
                     ^~~~~~~~~~
procfs.c:3303:20: note: suggested alternative: 'buildargv'
    for (char *arg : built_argv)
                     ^~~~~~~~~~
                     buildargv

This is it - after all of above ones are fixed current binutilities/gdb do
compile fine on illumos, btw. I didn't knew that gdb is part of
binutilities, if 2.38 will be released will it also contain this gdb 
release?

Many Regards
Klaus

-- 
You are receiving this mail because:
You are on the CC list for the bug.