[Bug binutils/29891] New: Out of bound read at `case DST__K_TERM

bug-binutils
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug binutils/29891] New: Out of bound read at `case DST__K_TERM_W` hand

From:	r3tr0spect2019 at gmail dot com
Subject:	[Bug binutils/29891] New: Out of bound read at `case DST__K_TERM_W` handler in function `parse_module`
Date:	Mon, 12 Dec 2022 03:44:42 +0000
https://sourceware.org/bugzilla/show_bug.cgi?id=29891

            Bug ID: 29891
           Summary: Out of bound read at `case DST__K_TERM_W` handler in
                    function `parse_module`
           Product: binutils
           Version: 2.40 (HEAD)
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: binutils
          Assignee: unassigned at sourceware dot org
          Reporter: r3tr0spect2019 at gmail dot com
  Target Milestone: ---

Created attachment 14512
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14512&action=edit
PoC

# Reproduce

```bash
cd binutils-gdb
git reset --hard f2f58a399cf3f946983398cdfe52d0eaa72bf877
mkdir build && cd build
../configure --disable-gdb --disable-gdbserver --disable-gdbsupport
--disable-libdecnumber --disable-readline --disable-sim --disable-libbacktrace
--disable-gas --disable-ld --disable-werror --enable-targets=all
CPPFLAGS=-DDEBUG CFLAGS="-g -O0 -fsanitize=address"
make all-binutils MAKEINFO=true && true
binutils/addr2line -e poc.bin 0
```

# Output

```
binutils/addr2line: unknown line command 127
binutils/addr2line: unknown line command 117
binutils/addr2line: unknown line command 73
binutils/addr2line: unknown line command 63
binutils/addr2line: unknown line command 116
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: DST__K_END_STMT_MODE not implemented
binutils/addr2line: unknown line command 73
binutils/addr2line: DST__K_END_STMT_MODE not implemented
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: unknown line command 38
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: unknown line command 27
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: unknown line command 92
binutils/addr2line: unknown line command 94
binutils/addr2line: unknown line command 95
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 85
binutils/addr2line: unknown line command 65
binutils/addr2line: unknown line command 65
binutils/addr2line: unknown line command 65
binutils/addr2line: unknown line command 65
binutils/addr2line: unknown line command 83
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: unknown line command 65
binutils/addr2line: unknown line command 72
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: unknown line command 100
binutils/addr2line: unknown line command 59
binutils/addr2line: unknown line command 115
binutils/addr2line: unknown line command 100
binutils/addr2line: unknown line command 40
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 112
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 127
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 63
binutils/addr2line: unknown line command 116
binutils/addr2line: unknown line command 73
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 127
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 127
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 63
binutils/addr2line: unknown line command 55
binutils/addr2line: unknown line command 49
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 127
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 39
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 116
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: unknown line command 117
binutils/addr2line: unknown line command 73
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 127
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 39
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 127
binutils/addr2line: unknown line command 65
binutils/addr2line: unknown line command 28
binutils/addr2line: unknown line command 49
binutils/addr2line: unknown line command 116
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 116
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: unknown line command 117
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 117
binutils/addr2line: unknown line command 73
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 127
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 39
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 127
binutils/addr2line: unknown line command 65
binutils/addr2line: unknown line command 28
binutils/addr2line: unknown line command 49
binutils/addr2line: unknown line command 116
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 116
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 127
binutils/addr2line: unknown line command 117
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 39
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 23
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 117
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: unknown line command 72
binutils/addr2line: DST__K_END_STMT_MODE not implemented
binutils/addr2line: unknown line command 91
binutils/addr2line: unknown line command 113
binutils/addr2line: unknown line command 93
binutils/addr2line: unknown line command 94
binutils/addr2line: unknown line command 95
binutils/addr2line: unknown line command 68
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 56
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 68
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 56
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 85
binutils/addr2line: unknown line command 65
binutils/addr2line: unknown line command 65
binutils/addr2line: unknown line command 65
binutils/addr2line: unknown line command 65
binutils/addr2line: unknown line command 83
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 83
binutils/addr2line: unknown line command 73
binutils/addr2line: unknown line command 65
binutils/addr2line: unknown line command 72
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: unknown line command 56
binutils/addr2line: unknown line command 116
binutils/addr2line: unknown line command 64
binutils/addr2line: unknown line command 73
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 117
binutils/addr2line: unknown line command 73
binutils/addr2line: unknown line command 73
binutils/addr2line: unknown line command 73
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 107
binutils/addr2line: unknown line command 73
binutils/addr2line: unknown line command 69
binutils/addr2line: unknown line command 65
binutils/addr2line: unknown line command 69
binutils/addr2line: unknown line command 73
binutils/addr2line: unknown line command 69
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 127
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: unknown line command 100
binutils/addr2line: unknown line command 59
binutils/addr2line: unknown line command 115
binutils/addr2line: unknown line command 100
binutils/addr2line: unknown line command 42
binutils/addr2line: DST__K_SET_LINUM_INCR not implemented
binutils/addr2line: unknown line command 127
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 112
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 83
binutils/addr2line: unknown line command 127
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 99
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 123
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 55
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 83
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 75
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 123
binutils/addr2line: unknown line command 73
binutils/addr2line: unknown line command 116
binutils/addr2line: unknown line command 73
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 127
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 127
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 63
binutils/addr2line: unknown line command 50
binutils/addr2line: unknown line command 65
binutils/addr2line: unknown line command 49
binutils/addr2line: unknown line command 69
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 123
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 83
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: DST__K_SET_LINUM_INCR_W not implemented
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 127
binutils/addr2line: DST__K_SET_LINUM_INCR not implemented
binutils/addr2line: unknown line command 73
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 127
binutils/addr2line: DST__K_SET_LINUM_INCR not implemented
binutils/addr2line: unknown line command 72
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 73
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 67
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 112
binutils/addr2line: unknown line command 123
binutils/addr2line: unknown line command 49
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 127
binutils/addr2line: DST__K_SET_LINUM_INCR not implemented
binutils/addr2line: unknown line command 73
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 127
binutils/addr2line: DST__K_SET_LINUM_INCR not implemented
binutils/addr2line: unknown line command 76
binutils/addr2line: unknown line command 99
binutils/addr2line: unknown line command 73
binutils/addr2line: DST__K_RESET_LINUM_INCR not implemented
binutils/addr2line: unknown line command 72
binutils/addr2line: DST__K_BEG_STMT_MODE not implemented
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 67
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 120
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 72
binutils/addr2line: unknown line command 127
=================================================================
==174799==ERROR: AddressSanitizer: heap-buffer-overflow on address
0x61a000000b81 at pc 0x5571b6280c4e bp 0x7fff7fec65a0 sp 0x7fff7fec6590
READ of size 1 at 0x61a000000b81 thread T0
    #0 0x5571b6280c4d in bfd_getl16 ../../bfd/libbfd.c:633
    #1 0x5571b6841421 in parse_module ../../bfd/vms-alpha.c:4704
    #2 0x5571b6841fad in module_find_nearest_line ../../bfd/vms-alpha.c:4902
    #3 0x5571b6842911 in _bfd_vms_find_nearest_line ../../bfd/vms-alpha.c:4982
    #4 0x5571b626eb1e in find_address_in_section ../../binutils/addr2line.c:197
    #5 0x5571b6289f43 in bfd_map_over_sections ../../bfd/section.c:1366
    #6 0x5571b626f8eb in translate_addresses ../../binutils/addr2line.c:337
    #7 0x5571b626ffbc in process_file ../../binutils/addr2line.c:470
    #8 0x5571b62705b1 in main ../../binutils/addr2line.c:579
    #9 0x7ff7a3515d8f in __libc_start_call_main
../sysdeps/nptl/libc_start_call_main.h:58
    #10 0x7ff7a3515e3f in __libc_start_main_impl ../csu/libc-start.c:392
    #11 0x5571b626e244 in _start
(/binutils-gdb/build/binutils/addr2line+0x343244)

0x61a000000b81 is located 1 bytes to the right of 1280-byte region
[0x61a000000680,0x61a000000b80)
allocated by thread T0 here:
    #0 0x7ff7a37c8867 in __interceptor_malloc
../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
    #1 0x5571b62808d5 in bfd_malloc ../../bfd/libbfd.c:289
    #2 0x5571b682b13a in _bfd_malloc_and_read ../../bfd/libbfd.h:970
    #3 0x5571b6841f77 in module_find_nearest_line ../../bfd/vms-alpha.c:4896
    #4 0x5571b6842911 in _bfd_vms_find_nearest_line ../../bfd/vms-alpha.c:4982
    #5 0x5571b626eb1e in find_address_in_section ../../binutils/addr2line.c:197
    #6 0x5571b6289f43 in bfd_map_over_sections ../../bfd/section.c:1366
    #7 0x5571b626f8eb in translate_addresses ../../binutils/addr2line.c:337
    #8 0x5571b626ffbc in process_file ../../binutils/addr2line.c:470
    #9 0x5571b62705b1 in main ../../binutils/addr2line.c:579
    #10 0x7ff7a3515d8f in __libc_start_call_main
../sysdeps/nptl/libc_start_call_main.h:58

SUMMARY: AddressSanitizer: heap-buffer-overflow ../../bfd/libbfd.c:633 in
bfd_getl16
Shadow bytes around the buggy address:
  0x0c347fff8120: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c347fff8130: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c347fff8140: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c347fff8150: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c347fff8160: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0c347fff8170:[fa]fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c347fff8180: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c347fff8190: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c347fff81a0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c347fff81b0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c347fff81c0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
  Shadow gap:              cc
==174799==ABORTING
Aborted (core dumped)
```

# Analysis

`pcl_ptr + DST_S_W_PCLINE_UNSWORD` is accessed without check.[1]

[1]
https://github.com/bminor/binutils-gdb/blob/85f9067d3a47d51a46ba369c60fdec752da0f885/bfd/vms-alpha.c#L4704

-- 
You are receiving this mail because:
You are on the CC list for the bug.
[Prev in Thread]
Current Thread
[Next in Thread]
[Bug binutils/29891] New: Out of bound read at `case DST__K_TERM_W` handler in function `parse_module`, r3tr0spect2019 at gmail dot com <=
- [Bug binutils/29891] Out of bound read at `case DST__K_TERM_W` handler in function `parse_module`, amodra at gmail dot com, 2022/12/12
- [Bug binutils/29891] Out of bound read at `case DST__K_TERM_W` handler in function `parse_module`, cvs-commit at gcc dot gnu.org, 2022/12/12
- [Bug binutils/29891] Out of bound read at `case DST__K_TERM_W` handler in function `parse_module`, amodra at gmail dot com, 2022/12/12
Prev by Date: [Bug binutils/29890] New: Out of bound read at `case DST__K_SRC_SETREC_W` handler in function `parse_module`
Next by Date: [Bug binutils/29892] New: Field `file_table` of `struct module *module` is uninitialized
Previous by thread: [Bug binutils/29890] New: Out of bound read at `case DST__K_SRC_SETREC_W` handler in function `parse_module`
Next by thread: [Bug binutils/29891] Out of bound read at `case DST__K_TERM_W` handler in function `parse_module`
Index(es):
- Date
- Thread