|
| From: | Paul Eggert |
| Subject: | Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib |
| Date: | Mon, 05 Mar 2012 09:58:02 -0800 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 |
The overall idea looks good. A few minor comments: +/* The quoting option used by quote_n and quote. */ +static struct quoting_options quote_quoting_options_ = Remove "static"; it's ineffective and misleading here. +/*----------------------. +| Former quote module. | +`----------------------*/ No need to put history into the commentary, so please remove this. Can you push this into gnulib? If not, I'll volunteer.
| [Prev in Thread] | Current Thread | [Next in Thread] |