[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Building and testing Bison 3.0.2 with MinGW [3/5]
From: |
Eli Zaretskii |
Subject: |
Re: Building and testing Bison 3.0.2 with MinGW [3/5] |
Date: |
Sat, 17 Jan 2015 11:39:09 +0200 |
> From: Akim Demaille <address@hidden>
> Date: Sat, 17 Jan 2015 09:52:39 +0100
> Cc: Bison Bugs <address@hidden>
>
> > Le 16 janv. 2015 à 16:39, Eli Zaretskii <address@hidden> a écrit :
> >
> >> From: Akim Demaille <address@hidden>
> >> Or maybe something in gnulib?
> >
> > Last time I checked even gnulib's 'setlocale' didn't solve this
> > problem.
>
> Shouldn't we suggest them to address the issue there?
Perhaps.
> > Or maybe the tests should do something else than LC_ALL=C to disable
> >> internationalization?
> >
> > The only thing that will work on Windows is to call 'setlocale' with
> > LC_ALL=C, but I don't see how you can do that since Bison is a
> > program, not a library.
> >
> > What is the problem with my suggested fix? If you don't like it in
> > main.c, we could make it a function in some Windows-specific source
> > file.
>
> Yes, I'm trying to avoid any #ifdef in the code,
> and to hide everything in the library. In this case,
> I'd prefer something in src/system.h than in src/main.c.
I can work on a patch like that, if you'd like me to.
> Or a lib/setlocale.c, indeed.
That's gnulib, isn't it? If we make the change there, the next time
you update from gnulib, those changes will be obliterated.
Thanks.
- Re: Building and testing Bison 3.0.2 with MinGW [3/5], Akim Demaille, 2015/01/16
- Re: Building and testing Bison 3.0.2 with MinGW [3/5], Eli Zaretskii, 2015/01/16
- Re: Building and testing Bison 3.0.2 with MinGW [3/5], Akim Demaille, 2015/01/17
- Re: Building and testing Bison 3.0.2 with MinGW [3/5],
Eli Zaretskii <=
- Re: Building and testing Bison 3.0.2 with MinGW [3/5], Akim Demaille, 2015/01/17
- Re: Building and testing Bison 3.0.2 with MinGW [3/5], Eli Zaretskii, 2015/01/20
- Re: Building and testing Bison 3.0.2 with MinGW [3/5], Akim Demaille, 2015/01/22
- Re: Building and testing Bison 3.0.2 with MinGW [3/5], Eli Zaretskii, 2015/01/26
- Re: Building and testing Bison 3.0.2 with MinGW [3/5], Akim Demaille, 2015/01/27
- Re: Building and testing Bison 3.0.2 with MinGW [3/5], Eli Zaretskii, 2015/01/27
- Re: Building and testing Bison 3.0.2 with MinGW [3/5], Akim Demaille, 2015/01/29