bug-bison
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bison 3.7.90 (beta)


From: Akim Demaille
Subject: Re: Bison 3.7.90 (beta)
Date: Thu, 19 Aug 2021 08:49:09 +0200

Dagobert,

> Le 18 août 2021 à 16:28, Dagobert Michelsen <dam@opencsw.org> a écrit :
> 
>> BTW, please also run `make check-tests`.  Because you had errors in the 
>> tests of the examples, the main test suite was not run.
> 
> There are quite a lot of failures:
>  testsuite: 4 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 
> 487 48 500 failed
> 
> The log is attached:
> 
> <testsuite.log>

There are two issues here: that of 4, and that of all the others (the message 
looks wrong, it says "487 48 500", but it should be "487 488 489 500").

For the second part, I, again, used grep -E.  So I'm installing this.

commit 3afa9757da056e2dc2abf56b0abb7b4276c030d7
Author: Akim Demaille <akim.demaille@gmail.com>
Date:   Thu Aug 19 08:21:23 2021 +0200

    tests: grep -E is not portable
    
    Reported by Dagobert Michelsen.
    <https://lists.gnu.org/r/bug-bison/2021-08/msg00008.html>
    
    * tests/calc.at: Use $EGREP.

diff --git a/tests/calc.at b/tests/calc.at
index 831a2b08..11801543 100644
--- a/tests/calc.at
+++ b/tests/calc.at
@@ -970,7 +970,7 @@ m4_define([_AT_CHECK_CALC],
   [AT_PARSER_CHECK([calc $1 input],        0, [m4_ifvaln(m4_quote($3), [$3])], 
[stderr])])
 AT_LANG_MATCH([c\|c++\|java],
   [AT_GLR_IF([],
-    [AT_CHECK([grep -c -v -E 'Return for a new token:|LAC:' stderr],
+    [AT_CHECK([$EGREP -c -v 'Return for a new token:|LAC:' stderr],
               [ignore],
               [m4_n([AT_DEBUG_IF([$4], [0])])])])])
 ])




reply via email to

[Prev in Thread] Current Thread [Next in Thread]