bug-commoncpp
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Release 7.0.1


From: Jeffrey Walton
Subject: Re: Release 7.0.1
Date: Sun, 20 Sep 2020 12:40:36 -0400

On Sun, Sep 20, 2020 at 11:55 AM David Sugar <dyfet@gnutelephony.org> wrote:
>
> I think I have all the changes needed for a 7.0.1 release in now.
>
> I did bring in some downstream patches from Debian, and minimally fixed
> support for openssl 1.1.  A lot of the rest was code cleanup and a few small
> bug fixes, as well as getting rid of some obsolete build things we had
> accumulated.  One can use either automake or cmake to configure.
>
> I will give some time for any additional patches, suggested changes or build
> fixes, and probably try to do a release by next weekend.

If you setup a RC branch we can take look at things before the release.

Shooting from the hip, all OpenSSL function return values should be
checked. The current code ignores return values.

Also, the C++ exception specifications should be removed. They fell
out of favor a long time ago for C++03, and are not recommended any
longer. About the only place they show up nowadays is when a
destructor throws, and it is declared with 'noexcept(false)'.

This should help. It preserves the filetimes.

IFS="" find "./" -type f -name '*.*' -print | while read -r file
do

    if ! grep -q 'throw(PersistException)' "${file}"; then
        continue
    fi

    # Display filename, strip leading "./"
    echo "$file" | tr -s '/' | cut -c 3-

    touch -a -m -r "$file" "$file.timestamp"

    sed -e 's/ throw(PersistException)//g' \
        "$file" > "$file.fixed" && \
    mv "$file.fixed" "$file"

    touch -a -m -r "$file.timestamp" "$file"
    rm "$file.timestamp"
done

Jeff



reply via email to

[Prev in Thread] Current Thread [Next in Thread]