Re: Two CVS feature enhancement requests (trivial but VERY useful)

[Derek R. Price]

Mark Lindner wrote:

> The first change involves adding the following logic to the end of the
> remove_entry_and_file() function in client.c:
>
>     else
>       {
>       char *p = short_pathname;
>
>       if(strlen(p) > 2)
>         if(!strncmp(p, "./", 2))
>           p += 2;
>
>       cvs_output("X ", 0);
>       cvs_output(p, 0);
>       cvs_output("\n", 1);
>       }
>
> This causes CVS to print out an update record for files that have been deleted
> from the repository since the last update, e.g.:
>
> U src/foo.c
> A src/bar.c
> X src/baz.c
>
> which means foo.c was updated, bar.c was added, and baz.c was removed. This
> makes it much easier for tools and scripts that use CVS to determine that a
> file has been removed (the alternative was to parse the stderr output for "xxx
> is no longer pertinent" warnings, which was ugly).

Don't know if I can get this change past the other developers, but I like it.
Unfortunately, your X lines are getting past the dotest wrappers in sanity.sh
which usually means they're going out on the wrong file descriptor somehow.
Perhaps the server is actually _printing_ them?  Also, you're not suppressing 
the
old warnings.  Are you sure that the new line shouldn't just take the place of
the warnings?  And patches are supposed to include sanity.sh test cases,
ChangeLog entries, and any necessary doc changes.  It makes it much more likely
your change will get in in a timely manner, assuming the idea is accepted at 
all.

Derek
--
Derek Price                      CVS Solutions Architect ( http://CVSHome.org )
mailto:dprice@openavenue.com     OpenAvenue ( http://OpenAvenue.com )
--
If nature has made any one thing less susceptible than all others of exclusive
property, it is the action of the thinking power called an idea, which an
individual may exclusively possess as long as he keeps it to himself; but the
moment it is divulged, it forces itself into the possession of everyone, and
the receiver cannot dispossess himself of it.  Its peculiar character, too, is
that no one possesses the less, because every other possesses the whole of it.
He who receives an idea from me, receives instruction himself without lessening
mine; as he who lights his taper at mine, receives light without darkening me.
That ideas should freely spread from one to another over the globe, for the
moral and mutual instruction of man, and improvement of his condition, seems to
have been peculiarly and benevolently designed by nature, when she made them,
like fire, expansible over all space, without lessening their density at any
point, and like the air in which we breathe, move, and have our physical being,
incapable of confinement or exclusive appropriation. Inventions then cannot, in
nature, be a subject of property.

   - Thomas Jefferson