Re: Bug on cvs commit v1.11

[Karl Fogel]

"Pierre CETEAUD" <pceteaud@macif.fr> writes:
> Looking to the code on codecatalog.com I read :
> 
> 2054      if (rcsnode != NULL)
>  2055     {
>  2056         assert (*rcsnode == NULL);
>  2057         *rcsnode = rcsfile;
>  2058     }
> 
> Everyone can see that line 2057 will never be executed. There's
> something wrong 
> 
> I gess that on of the to line 2054 or 2056 as inverted the condition
> (probably line 2056 should be :  assert (*rcsnode != NULL);    if it
> has any utility )

I don't know the root cause of the commit failing, but note that line
2057 *can* be reached, because:

   line 2054 is testing `rcsnode'   (a memory address)
   line 2056 is testing `*rcsnode'  (the value at that address)

There is no inherent problem with the logic in those lines.

-K