[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 2 CVS bugs

From: Larry Jones
Subject: Re: 2 CVS bugs
Date: Mon, 2 Apr 2001 14:51:56 -0400 (EDT)

Derek R. Price writes:
> Whoops, just noticed you sent me the patch for getdate.c & not getdate.y.  So

Actually, they were both there.

> I researched the yyparse() prototype a little farther.  Bison (GNU yacc) 
> appears
> to generate prototypes for yyparse() automatically.  Apparently it's not 
> anything
> a user should override because it ifdef's on some things like YYPARSE_PARAM &
> __cplusplus for various reasons.

Note that it's also conditional on __GNUC__, so it's not generally
useful.  I endorse the suggested change -- declaring it without a
prototype finesses the question of the number and types of arguments
(which is what YYPARSE_PARAM is dealing with) but avoids the implicit
declaration (which more and more compilers are starting to warn about,
particularly since it's invalid in C99).  In my case, I was working with
the development source, but getdate.y was newer than getdate.c so make
rebuilt getdate.c using my version of bison which does not automatically
generate a declaration (and I don't know of any version of yacc that
generates a declaration).

-Larry Jones

I won't eat any cereal that doesn't turn the milk purple. -- Calvin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]