RE: Fix for checking out inside of repository with nfs and automo unt

[Cameron, Steve]

Hi Donald, 
> On Wed, May 23, 2001 at 05:11:11PM -0500, Cameron, Steve wrote:
> >     Donald Sharp wrote:
> >     [...] 
> > > This patch modifies the current behaviour of checkout.c,
> safe_location()
> > > to assume that you are not inside of the repository if you are using
> cvs
> > > in a remote manner.
> >     [smc]  is this a safe assumption?  If I have my home driectory nfs
> 
> I don't know if it is a safe assumption. 
> 
> It assumes that when people use remote repositories the drive
> that the repository is on is not available any where else.
        [...] 
> But the repository isn't in your home directory right?
        [smc]  Correct.  The nfs-mounted home directory example was only to
show that there is at least one situation where it's totally reasonable to
access a repository by a remote access method even when the repository is
available locally.  And, in that case, it's not completely safe to assume
that the repository is not availabe locally just because the access method
is remote.

        I could do something dumb like this:

        [me@somewhere ] $ rsh cvsserver
        [me@cvsserver me] $ echo $CVSROOT
        :pserver:me@cvsserver:/cvsroot
        [me@cvsserver me[ $ cd /cvsroot
        [me@cvsserver cvsroot] $  # At this point, maybe I went out to
lunch...
        [me@cvsserver cvsroot] $ cvs co whatever  # I forgot what preceded,
thought I was in a different window, etc....

        I'm not sure what CVS did before in this situation, so your patch
may not make this any worse than it was before, and no doubt improves some
situations.  All I'm saying is, "look at this, is this a hole somebody could
step into?"  It may be the case that the assumption is deemed "safe
enough"...and if you shoot yourself in the foot, you will be hurting for
awhile, so "don't do that".
>  
        -- steve