[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Broken CVS tree?

From: Derek R. Price
Subject: Re: Broken CVS tree?
Date: Wed, 20 Jun 2001 14:41:26 -0400

Larry Jones wrote:

> Jerzy Kaczorowski writes:
> >
> > --------------------Configuration: cvsnt - Win32 Debug--------------------
> > Compiling...
> > client.c

[. . .]

> Derek, this looks like a result of your changes a month and a half ago.
> The errors are in the NO_SOCKET_TO_FD code that isn't used on Unix, so
> it hasn't been noticed, but it's definitely broken.

Yep.  That was my fault.  I applied a fix which compiled and passed cursory
tests (it updated itself from the server) on Linux but I don't have a working
Windows box to test on.

The code still prints one extraneous warning which I'm not sure I'm ready to get
rid of.

Interestingly enough, it looks like some of the windows code is actually using
sockets and FDs interchangably, so I'd be interested to hear what happens if the
#define NO_SOCKET_TO_FD line is commented out from windows-NT/system.h before
building.  It could be legacy...

Checked in!  Thanks!


Derek Price                      CVS Solutions Architect ( http://CVSHome.org )
mailto:dprice@collab.net         CollabNet ( http://collab.net )
I will not drive the principal's car.
I will not drive the principal's car.
I will not drive the principal's car...

          - Bart Simpson on chalkboard, _The Simpsons_

reply via email to

[Prev in Thread] Current Thread [Next in Thread]