Re: [PATCH] do_editor needs to mind access method

[Derek R. Price]

darkness wrote:

>         Greetings.
>
>         When running "cvs import" with
> CVSROOT=:pserver:foo@localhost:/path/to/cvsroot I would get the error:
>
> cvs import: cannot open /path/to/cvsroot/CVSROOT/rcsinfo: Permission denied

I managed to reproduce this and checked in a fix.  I didn't use your exact fix
since it seemed that in all cases except import repository was set correctly in
regards to local/client mode for the do_editor function, so I set it in the
caller instead.

I also added an assertion, so I'm not really sure I'm saving ops, but I was
going for consistency at the moment.  It might be interesting to add a DEV_MODE
flag or the like that turns some of the assertions on and off, but I'm not so
sure.  Anyway, I'll keep it in mind.

Thanks for the report and patch!

Derek

--
Derek Price                      CVS Solutions Architect ( http://CVSHome.org )
mailto:dprice@collab.net         CollabNet ( http://collab.net )
--
f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng