Re: failure_exit not cleared in client.c

[Derek R. Price]

Initializing this variable seems correct at face value, but the fact that it
wasn't generating any errors from the test script makes me suspicious that it
wasn't actually being used.  Also, it shouldn't be using a global in the first
place - the errors should be returned properly up the function call change
though this doesn't necessarily need to be done now.  Lastly, I don't think the
variable needs to be initialized with every call to start_server() since it is
setting the process return code and if it a single call to CVS was supposed to
exit with an error code for any reason, that shouldn't change with additional
server starts.

Can you create a script that duplicates this error?  One that fits in sanity.sh
would be best if you can handle it.

I created an IssueZilla issue to track this.  If you haven't already registered
and requested an observer role on the ccvs project, do so and you can add
yourself to the CC list:  http://ccvs.cvshome.org/issues/show_bug.cgi?id=36

Derek

--
Derek Price                      CVS Solutions Architect ( http://CVSHome.org )
mailto:dprice@collab.net         CollabNet ( http://collab.net )
--
I find that the harder I work, the more luck I seem to have.

                        - Thomas Jefferson

Vesa Suontama wrote:

> Hello,
>
> I noticed that the variable failure_exit in src/client.c (version 1.1) is
> never cleared, when doing cvs updates.
>
> It sometimes happens that the failure_exit is set around the line 1790. (For
> example the case that you have a local file that is "on the way").