Re: failure_exit not cleared in client.c

[Larry Jones]

Ian Lance Taylor writes:
> 
> A typical case is that the file is somehow modified after the CVS
> process starts, so the application of the patch fails.  Another is
> that the file contains binary data, but is not marked as -kb, and
> patch gets confused.

Ah, I see I misunderstood the question.  There are *two* loops involving
patching files, one on the server and another on the client.  The
phrasing of the question ("making the file unpatchable") lead me to
think we were talking about the server loop, since it's the server that
decides whether a file is patchable or not.  The question was really,
"what would cause the patch to fail?" (on the client).  In addition to
the cases Ian mentioned, another possibility is that the file has
changed without CVS noticing (because the timestamp didn't change).  In
addition to various nefarious ways of causing that, sharing a working
directory between platforms with different line-ending conventions will
have that effect.

-Larry Jones

If I was being raised in a better environment, I wouldn't
do things like that. -- Calvin