RE: Allowing regular expression in --allow-root option

[Hier, Steve]

I'm not the one that is/was suggesting the regexp patch -- I was merely
adding my voice in support of such a change to the original poster.

-----Original Message-----
From: Derek R. Price [mailto:dprice@collab.net]
Sent: Friday, October 12, 2001 11:24 AM
To: Hier, Steve
Cc: 'Christian BAYLE'; bug-cvs@gnu.org
Subject: Re: Allowing regular expression in --allow-root option


"Hier, Steve" wrote:

> I've been using a patch like this for years -- it is quite handy to be
able
> to specify a "family" of directories that are valid instead of creating
> some huge (in many cases too large to pass) command line...
>
> Regular expressions would be an improvement from what I'm using.
> My patch allows one to specify the a "root node" from which repositories
> can be used under.

I'm not sure how generally useful this is, but I also can't really see it as
a
bad thing.

I don't like this fix though, for a number of reasons:

1)  You haven't attached a ChangeLog entry, doc/cvs.texinfo documentation
changes, or src/sanity.sh test cases.  See the HACKING file in the top level
of the CVS source distribution for more.

2)  I don't want the old behavior of the --alow-root option changed.  Add a
--allow-root-regexp option.

3)  If we're going to go this far, full regexps should be allowed.  The
argument to --allow-root-regexp should be matched against the entire path.

If you want to go ahead with this, create an issue on ccvs.cvshome.org with
this information, including the above design considerations and any comments
you may like to add, then create the new patch and attach it to the issue.

Derek

--
Derek Price                      CVS Solutions Architect (
http://CVSHome.org )
mailto:dprice@collab.net         CollabNet ( http://collab.net )
--
A burp is not an answer.
A burp is not an answer.
A burp is not an answer...

          - Bart Simpson on chalkboard, _The Simpsons_