[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: loginfo processing (logmsg.c) bug

From: Derek Robert Price
Subject: Re: loginfo processing (logmsg.c) bug
Date: Fri, 16 Aug 2002 14:58:12 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.0) Gecko/20020606

Andrey Aristarkhov wrote:


I've found a bug in loginfo processing. The problem is that if file to
be committed contains spaces, for instance, "Read Me.txt", format string
%{sVv} expanded like (1) Read Me.txt,oldRev,newRev, but should be (1) Read\ Me.txt,oldRev,newRev
In first case filter script takes 2 paramters and in second case -
single parameter.

I've wrote a patch to solve this problem. Please apply in ccvs/src

Andrey Aristarkhov

The problem with that is that it would break backwards compatibility, though it is possible that noone is using file names with spaces in them since this has never worked. I don't believe it is documented this way either.

I don't suppose you would be willing to test out this patch: <http://ximbiot.com/ccvs.newfmtstrings.1-11.diff>? Among other things it unifies the format of the *info file command templates and IIRC provides for paths with spaces by quoting them or the like while allowing for backwards compatibility.

I've been trying to get this patch tested for awhile now. A few people have volunteered but never gave any feedback. Hopefully it still applies without trouble. There should be docs and test cases included. I believe the patch was against 1.11.

Let me know if there's anything else I can do.



Email: derek@ximbiot.com

Get CVS support at http://ximbiot.com
I will not drive the principal's car.
I will not drive the principal's car.
I will not drive the principal's car...

         - Bart Simpson on chalkboard, _The Simpsons_

reply via email to

[Prev in Thread] Current Thread [Next in Thread]