[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

CVS hangs on commit (fix against 1.11.2 enclosed)

From: pronovic
Subject: CVS hangs on commit (fix against 1.11.2 enclosed)
Date: Tue, 10 Sep 2002 16:15:48 -0500

Synopsis:       CVS hangs on commit
Severity:       serious
Priority:       medium
Category:       CVS
Class:          sw-bug
Release:        1.11.2
System: Linux daystrom 2.4.18 #1 Mon Jun 24 16:21:48 CDT 2002 i686 unknown
Architecture: i686
Debian GNU/Linux 'testing'

   When committing and not adding a description, cvs does commit the files but 
also hangs afterwards, causing a stale lock. 
   See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=157881 for a recipe.
   Apply the following patch.

diff -r cvs-1.11.2-old/src/commit.c cvs-1.11.2-new/src/commit.c
<       /* We always send some sort of message, even if empty.  */
<       /* FIXME: is that true?  There seems to be some code in do_editor
<          which can leave the message NULL.  */
<       option_with_arg ("-m", saved_message);
>       /* Send a blank comment if the editor leaves it blank.  Otherwise,
>          we hang in an editor session on the server, which is bad.  */
>       if (saved_message)
>           option_with_arg ("-m", saved_message);
>       else
>           option_with_arg ("-m", "");

reply via email to

[Prev in Thread] Current Thread [Next in Thread]