[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: cvs 1.11.2 buffer.c blocking socket/pipe w/bugfix

From: Larry Jones
Subject: Re: cvs 1.11.2 buffer.c blocking socket/pipe w/bugfix
Date: Thu, 26 Sep 2002 16:07:18 -0400 (EDT)

Derek Robert Price writes:
> Can you suggest an alternative to get around the blocking problem?

It looks to me like we're just screwed.  The problem is that when old
clients use compression, they don't actually close the connection to the
server until after the server closes its connection to them.  The old
server didn't check for EOF on the input stream before closing it, so it
didn't matter, but the new server does and thus hangs.

I think our best course of action is to just remove the EOF check from
the input buffer case in stdio_buffer_shutdown(), which was the
originally suggested fix.  I don't like it, the old client behavior is
clearly wrong, but I think it's the lesser of two evils.

By the way, it looks to me like the two "if (server_active)"s in that
code should actually be "if (!server_active)"s, no?

-Larry Jones

I don't see why some people even HAVE cars. -- Calvin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]