Re: cvs rdiff -t consistently crashes with SEGV when processing files

[Mark D. Baushke]

Hi James,

Yes, I reproduced the problem on a Redhat 7.3 GNU/Linux system with a
2.4.18-27.7.x kernel using the cvs-1.11.1p1-8.7 package version of cvs.

I was also able to reproduce the problem on the same box using a stock
cvs-1.11.5 version.

I was NOT able to reproduce the problem with a cvs1-11-x-branch version
of the sources. I just tried and I was not able to reproduce the problem.

I therefore suggest you try using the sources I pointed to in my
previous response:

mdb wrote:
> This problem is already fixed in the development version of cvs
> (cvs1-11-x-branch). 
> 
> Use:
> 
> cvs -d :pserver:guest@cvs.cvshome.org:/cvs co -rcvs1-11-x-branch ccvs
> 
> to get your copy today. :-)

        Good luck,
        -- Mark

Using cvs-1.11.5 I see the following:

% gdb cvs
(gdb) run -d /tmp/cvs-rdiff-bug/repository rdiff -t m
Starting program: /homes/mdb/src/cvs/cvs-1.11.5/cvs-1.11.5/src/cvs -d /tmp/cvs-r
diff-bug/repository rdiff -t m
cvs rdiff: Diffing m

Program received signal SIGSEGV, Segmentation fault.
0x4207acfd in free () from /lib/i686/libc.so.6
(gdb) bt
#0  0x4207acfd in free () from /lib/i686/libc.so.6
#1  0x08072750 in patch_fileproc (callerdat=0x0, finfo=0xbfffd750)
    at patch.c:743
#2  0x0807d846 in do_file_proc (p=0x80cec88, closure=0xbfffd740)
    at recurse.c:832
#3  0x080625ca in walklist (list=0x80d11d0, proc=0x807d768 <do_file_proc>, 
    closure=0xbfffd740) at hash.c:370
#4  0x0807d684 in do_recursion (frame=0xbfffd7e0) at recurse.c:736
#5  0x0807dd4a in do_dir_proc (p=0x80ceb48, closure=0xbfffd888)
    at recurse.c:1096
#6  0x080625ca in walklist (list=0x80cef58, proc=0x807d86c <do_dir_proc>, 
    closure=0xbfffd888) at hash.c:370
#7  0x0807d712 in do_recursion (frame=0xbfffd920) at recurse.c:763
#8  0x0807d20a in start_recursion (fileproc=0x8071ac8 <patch_fileproc>, 
    filesdoneproc=0, direntproc=0x8072788 <patch_dirproc>, dirleaveproc=0, 
    callerdat=0x0, argc=0, argv=0x80ceb98, local=0, which=6, aflag=0, 
    locktype=1, update_preload=0x80ceb88 "m", dosrcs=1) at recurse.c:354
#9  0x08071ab1 in patch_proc (argc=1, argv=0x80cc1d0, xwhere=0x0, mwhere=0x0, 
    mfile=0x0, shorten=0, local_specified=0, mname=0x80ce788 "m", 
    msg=0x80b92e6 "Patching") at patch.c:356
#10 0x0806ee47 in do_module (db=0x80cc1e0, mname=0x80ce788 "m", m_type=PATCH, 
    msg=0x80b92e6 "Patching", callback_proc=0x80717ec <patch_proc>, where=0x0, 
    shorten=0, local_specified=0, run_module_prog=0, build_dirs=0, 
    extra_arg=0x0) at modules.c:299
#11 0x080717b9 in patch (argc=3, argv=0x80ce738) at patch.c:255
#12 0x0806db29 in main (argc=3, argv=0x80ce730) at main.c:991
#13 0x42017589 in __libc_start_main () from /lib/i686/libc.so.6
(gdb) up
#1  0x08072750 in patch_fileproc (callerdat=0x0, finfo=0xbfffd750)
    at patch.c:743
743             free (vers_tag);
(gdb) p vers_tag
$1 = 0x8072ac3 
"\215e%/1€Œiso8859-15ô\211%/1€Œiso8859-15Ø[^_]%/1€Œiso8859-15Ã\215v"
(gdb) 

James Cribb <gjc@fortisclearing.com.au> writes:

> I just built cvs-1.11.5.tar.bz2 from cvshome.org and it too crashes with
> SEGV on the same command in the script.
> 
> It happens on more than one machine here (SMP kernels 2.4.19 and 2.4.2),
> so it's not a hardware problem.
> 
> Here is the "version" part of the output from the original script:
> 
> 
> #----------------------------------------------------------------------
> # System details
> cvs -version
> 
> Concurrent Versions System (CVS) 1.11.5 (client/server)
> 
> Copyright (c) 1989-2002 Brian Berliner, david d `zoo' zuhn,
>                         Jeff Polk, and other authors
> 
> CVS may be copied only under the terms of the GNU General Public
> License,
> a copy of which can be found with the CVS distribution kit.
> 
> Specify the --help option for further information about CVS
> 
> rpm -qf `which cvs`
> which cvs
> file /home/gjc/cvs/cvs-1.11.5/src/cvs is not owned by any package
> rpm -q kernel
> kernel-2.4.2-2
> uname -a
> Linux svlx-fcs062 2.4.19 #3 SMP Fri Jan 10 13:42:32 EST 2003 i686
> unknown
> head -1 /etc/issue
> Red Hat Linux release 7.1 (Seawolf)