mac os x, gssapi too small buffer bug...

[Martin Algesten]

Hello!

I'm not sure exactly what triggers this problem but my setup is:

- Windows 2000 as KDC

- Mac OS X Server 10.2.4 as cvs server:
$ cvs --version

Concurrent Versions System (CVS) 1.10 `Halibut' (client/server)
...

- Linux as cvs client:
$ cvs --version

Concurrent Versions System (CVS) 1.11.1p1 (client/server)
...

I've configured the cvs/cvshost.my.domain.com principal and installed in
the keytab on the Mac OS X server. I've also setup the xinetd to do the
cvs pserver thing.

On the client side if I do:
$ cvs -d :gserver:martin@cvshost:/cvsroot/taglab history base

cvs [history aborted]: error from server cvshost:
/SourceCache/cvs/cvs-29/cvs/sr
c/server.c:5370: failed assertion `nbytes <= sizeof buf'

------ My first attempt to fix this was then to not use the Apple
default compiled cvs, but to get the latest source code and compile my
own... this however only resulted in exactly the same problem:

$ cvs -d :gserver:martin@cvshost:/cvsroot/taglab history base
cvs [history aborted]: error from server cvshost: server.c:5963: failed
assertion `nbytes <= sizeof buf'


The work around I arrived at was to increase the size of the buffer that
makes the assertion fail:

$ diff src/server.c-2003-04-08 src/server.c
5928c5928,5932
<     char buf[1024];
---
>
>     /* Changed by Martin Algesten 8/4/2003 to avoid assertion error
below. */
>     /* char buf[1024]; */
>     char buf[2048];
>


Compile and:
$ cvs -d :gserver:martin@cvshost:/cvsroot/taglab history base
O 2003-04-08 11:37 +0000 martin base          =base=
<remote>/*
...

Now I do not know much about GSSAPI and I don't know if my "fix" is a
fix for a problem or just a remedy for something which is incorrectly
setup in my local kerberos domain. I also don't know if increasing this
buffer size introduces any security/incompatibilty problems.

(Please CC me any replies)

Martin