Re: `cvs add -m' in server mode

[Derek Robert Price]

Mark D. Baushke wrote:

> Derek Robert Price <derek@ximbiot.com> writes:
>  
>
> > Does anyone have any strong feelings about me storing the file
> > description message from 'cvs add -m' in the timestamp field in the
> > CVS/Entries file after a `+' sign, like the conflict timestamp would
> > have been stored?  I'll have to encode the string to hide EOL & '/'s,
> > of course.
> >    
>
> I have no strong feelings about it. 
>
> However, given both the client and the server will need to agree on
> the meaning of the text for it to actually use the data, I would have
> thought introduction of another client/server primitive for setting
> the description of a controlled file might be the right way to do it.

Actually, this is exactly why I decided to do it this way.  I don't need 
a new primitive since the client sends the Entry to the server without 
interpreting it.  When the client does need to interpret it, it will 
(hopefully) ignore anything after the `+' since it parses it as the 
ts_conflict field and then will ignore it since it has a rev `0' which 
it knows is a new file.

If I'm correct, in other words, fixing this this way will allow the 
client/server problem to be fixed on the server side without upgrading 
clients.

> This could even lead to the extension of the 'cvs admin' command to
> update a description for a given file which would be a nice way to
> go back and describe all of the other files that have been missed for
> current client/server cvs users.

If I understand what you are suggesting, `cvs admin' already does this 
when passed the `-t' option, in local or client/server mode.

> > This would make RCS description field messages added with `add -m
> > <desc>' work in client/server mode.
> >    
>
> That would be nice.

:)

> > I'm about half-way to a prototype.  For some reason the add works but
> > then CVS exits with the wrong exit code but no error messages.  I'm
> > working on getting ot the bottom of that.
> >    

Derek

--
               *8^)

Email: derek@ximbiot.com

Get CVS support at <http://ximbiot.com>!
--
OPHELIA
 O, what a noble mind is here o'erthrown!
 The courtier's, soldier's, scholar's, eye, tongue, sword,
 Th'expectancy and rose of the fair state,
 The glass of fashion and the mould of form,
 Th'observed of all observers, quite, quite down!
 And I, of ladies most deject and wretched,
 That sucked the honey of his music vows,
 Now see that noble and most sovereign reason
 Like sweet bells jangled, out of time and harsh,
 That unmatched form and feature of blown youth
 Blasted with ecstasy.  O, woe is me
 T'have seen what I have seen, see what I see!

    - Hamlet, Act III, Scene 1, Lines 151-162