[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH],refreshed: [2/3] rename global to_/from_server

From: Derek Robert Price
Subject: Re: [PATCH],refreshed: [2/3] rename global to_/from_server
Date: Wed, 07 May 2003 16:35:32 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.2) Gecko/20030208 Netscape/7.02

Alexey Mahotkin wrote:

2003-05-02  Alexey Mahotkin <alexm@hsys.msk.ru>

Rename global from_/to_server variables to global_from_server and
global_to_server, to emphasize their meaning (it was lost in the maze
of local ones and impostor from_/to_server_p variables).

This is closer than your last few ChangeLog entries. A complete ChangeLog entry itemizes the changes by function, though. I do fudge this myself sometimes for changes like a global search/replace, but you still should have listed file names and maybe the names of the globals. Look at the way I've been rewriting your entries, perhaps. This one should be committed in an hour or so when the test finishes:

2003-05-07  Derek Price  <derek@ximbiot.com>

* client.c (from_server, to_server): Rename these global buffer pointers to...
        (global_from_server, global_to_server): ...this in order to avoid
        (Patch from Alexey Mahotkin <alexm@hsys.msk.ru>.)




Email: derek@ximbiot.com

Get CVS support at <http://ximbiot.com>!
Computer Lie #1: You'll never use all that disk space.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]