[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: SSL pserver, CVS

From: Derek Robert Price
Subject: Re: SSL pserver, CVS
Date: Thu, 29 May 2003 09:48:40 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.2) Gecko/20030208 Netscape/7.02

Alexey Mahotkin wrote:

"BM" == Brian Murphy <brian@murphy.dk> writes:

BM> You have not commented on the PAM stuff I have submitted though it
BM> seems relevant to your work, could you take a look at it.

Ok, I did a preliminary glance at it.

I believe that the following two things will have to be done:

- create pam-auth.c which contains all of the PAM code;

- PAM'ified version of check_system_password() must be called something
like check_pam_password() (and moved to pam-auth.c too).  Only the
invocation of those functions must be #ifdef'ed, not their definitions.
Two different functions with a same name is evil.

At least, current policy of code reorganization dictates this.  Derek will
confirm this (or not :)

Also, I'd suggest dropping ugly --with-hardcoded-pam-service-name (I had to
use copy-and-paste, that's insane!).  Hardcode "cvs".  Implement long
option --pam-service=SERVICE to 'cvs pserver' subcommand, which will
override this.  YMMV.

Anyway, do not bother if you wish.  I'll just clean it all up sooner or
later. :)

In that case, Alexey, I'll try and commit Brian's PAM patch soon and let you clean it up from there, unless you have objections?

By the way, what does "YMMV" stand for?



Email: derek@ximbiot.com

Get CVS support at <http://ximbiot.com>!
To err is human, to moo bovine.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]