[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tiny initialization refactoring in diff.c

From: Derek Robert Price
Subject: Re: [PATCH] tiny initialization refactoring in diff.c
Date: Wed, 04 Jun 2003 15:49:07 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.2) Gecko/20030208 Netscape/7.02

Alexey Mahotkin wrote:

"DRP" == Derek Robert Price <derek@ximbiot.com> writes:

>> I do not think that NULL-initializing deserves two lines of comments.
DRP> You might be right, but you'll need to submit this to the difflib
DRP> project to get it accepted.  I don't like maintaining unecessary
DRP> diffs to imported code.  It just makes for more problems on import of
DRP> new vendor releases.


there is a misunderstanding.  That patch is against src/diff.c, not
diff/diff.c.  It's CVS' own code.

DRP> In short, I'm rejecting this patch.  Sorry & thanks for trying.

"You Tried To Trick Me" (tm)

Please apply :)

Whoops.  You're right.  Sorry about that.

In any case, you'd made a convert of me and when I was working on the diff fix recently suggested by Paul Edwards, I cam across what I thought was a different case of the initializations with two lines of comments and tidied exactly as you did in this patch, so it's already on stable and should be checked into feature as soon as my `make check' finishes running on my merged workspace.

Thanks and sorry about that.  I'll try not to do it again.  :)



Email: derek@ximbiot.com

Get CVS support at <http://ximbiot.com>!
Pi R squared?!?! Nooo! Pie R round, cornbread R square!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]