[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch: trailing slash messes up export

From: Derek Robert Price
Subject: Re: patch: trailing slash messes up export
Date: Wed, 11 Jun 2003 15:06:23 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.2) Gecko/20030208 Netscape/7.02

Larry Jones wrote:

miles zarathustra writes:
I hope the cvs project will adopt this
patch, as the solution (removing the trailing / from CVSROOT) is not by any
means obvious, and it seems ridiculous to require it. If you are setting the
CVSROOT by hand, and use the <TAB> key in bash to get name completion, it
automatically appends the trailing /, so this fix should help avoid a
confusing and common problem.

Unfortunately, there are a lot of little things that don't work right
when CVSROOT has a trailing slash, so I strongly encourage you to get
used to removing it and not count on your patch to make everything work
right.  Unless, of course, you're willing to live with the fact that
things don't always work right (and it isn't always obvious that they
don't) and keep sending patches to fix them!  :-)

Larry meant to say, "Thanks!  Keep sending patches!"  :)

I'm testing and should soon check in a different change to parse_cvsroot() & local_cvsroot() in root.c to always parse the '/'s off of the end of a cvsroot. That should fix all cases where trailing slashes cause problems since they will not be seen by the rest of the program (aside from error messages, which can still get to current_parsed_root->original).



Email: derek@ximbiot.com

Get CVS support at <http://ximbiot.com>!
I will not carve gods.
I will not carve gods.
I will not carve gods...

         - Bart Simpson on chalkboard, _The Simpsons_

reply via email to

[Prev in Thread] Current Thread [Next in Thread]