[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Misdiffing of files without newlines

From: Andrew Moise
Subject: Re: Misdiffing of files without newlines
Date: Fri, 11 Jul 2003 19:05:18 -0400
User-agent: Mutt/1.5.4i

On Fri, Jul 11, 2003 at 03:22:02PM -0700, Paul Eggert wrote:
> The changes that you're proposing to context.c etc. implement the
> "\ No newline..." behavior in using a different method than diffutils,
> but I don't see the advantage of the way that you're proposing.

  It's not really a question of advantages so much as minimizing losses;
since CVS has hackery that sometimes readds the missing newline, we need
to either (a) put awareness of that hackery into diffutils code (which is
very ugly, but simple and small), or (b) get rid of that hackery, which
presumably will complexify the CVS code somewhat (which is right, but
might be complex and big.)  Without one of those, we get incorrect
behavior.  I did (a) for various reasons; I'll take a crack at (b) this
weekend unless someone can suggest a third option.  Maybe we'll get
lucky and something like putting a newline right past the end of the
buffer will suffice.

> At some point in this millennium I'd like to have a diffutils library
> that CVS can use.  In the meantime it'd be nicer to keep the two
> codebases close if possible.

  Yah, that makes sense.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]